Repository navigation
CI: drop persisted checkout credentials, guard with a YAML-parsed test - #2333
Closed
remigiusz-antczak wants to merge 1 commit into
Closed
remigiusz-antczak wants to merge 1 commit into
remigiusz-antczak wants to merge 1 commit into
Conversation
Every actions/checkout step in ci.yml and release.yml sets persist-credentials: false. The guard test now parses each workflow with yaml.safe_load instead of scanning text, so quoting, flow style, key case and run:/comment text cannot make it false-pass. The ignore-comment exemption is gone. It exits 2 when PyYAML, the directory or the workflow files are missing. Tests: 303/311 (scripts/test-ci-gates.sh; 8 fail from the sandbox serial_gate lock and a size budget already over on the base, none in files touched here) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Superseded by #2334. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #2332.
Sets
persist-credentials: falseon everyactions/checkoutstep inci.ymlandrelease.yml(zizmorartipacked), and addsscripts/test_workflow_persist_credentials.py, which fails CI if a workflow checkout keeps saved git credentials.Changes since #2332:
yaml.safe_loadand checks everyjobs.*.stepscheckout. The line-by-line scanner it replaces still let flow-style steps, quoted keys, uppercaseActions/Checkout, andwith:text insiderun:pass by mistake.Follow-up: the shipped
dcr-gates.ymltemplate checkout (needs a.claude/skillsregen).Local: the new test passes its self-checks.
scripts/test-ci-gates.shpassed 303 of 311, with 2 skipped. The 8 failures are the size budget, which fails on base too, and 7 sandbox serial-gate lock cases. CI will also confirm whether the runner's python3 ships PyYAML.🤖 Generated with Claude Code